benjamin/wgenerator
1
0
Fork 0
Code Releases Activity

fix transpose warning

Browse Source
This commit is contained in:
benjamin
2026-03-09 17:04:00 +01:00
parent a12e1ccb2f
commit f7e11b792c
1 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/app/modules/songs/services/transpose.service.ts
View File

@@ -33,7 +33,25 @@ export class TransposeService {
public getDistance(baseKey: string, targetKey: string): number {
const scale = getScaleType(baseKey);
return scale ? (scale[0].indexOf(targetKey) - scale[0].indexOf(baseKey) ?? scale[1].indexOf(targetKey) - scale[1].indexOf(baseKey)) % 12 : 0;
if (!scale) {
return 0;
}
const primaryBaseIndex = scale[0].indexOf(baseKey);
const primaryTargetIndex = scale[0].indexOf(targetKey);
if (primaryBaseIndex !== -1 && primaryTargetIndex !== -1) {
return (primaryTargetIndex - primaryBaseIndex) % 12;
}
const secondaryBaseIndex = scale[1].indexOf(baseKey);
const secondaryTargetIndex = scale[1].indexOf(targetKey);
if (secondaryBaseIndex !== -1 && secondaryTargetIndex !== -1) {
return (secondaryTargetIndex - secondaryBaseIndex) % 12;
}
return 0;
}
public getMap(baseKey: string, difference: number): TransposeMap | null {